Android 12 compartibility fixes. #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
A separate ticket is created to track the failed release job. |
Contributor
|
@Chaoba is it possible to separate this PR in 2 PRs:
I see no sense in messing it all up in one PR despite changes for leak canary, firebase etc are indeed related to Android 12 compatibility. |
pengdev
reviewed
Aug 17, 2021
Comment on lines
+55
to
+57
| implementation (dependenciesList.mapboxGeocoding, { | ||
| exclude group: 'com.squareup.okhttp3' | ||
| }) |
Member
There was a problem hiding this comment.
why do we exclude the okhttp specifically?
Contributor
Author
There was a problem hiding this comment.
It will conflict with another version of okhttp and cause a compile error.
tobrun
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included changes:
android:exported="true"in manifest and config for PendingIntent for Android 12