Invalidate onCameraMove as part of tracking animation #395
Conversation
| * @since 0.1.0 | ||
| */ | ||
| public final class LocationLayerPlugin implements LifecycleObserver { | ||
| public final class LocationLayerPlugin implements LifecycleObserver, OnCameraMoveInvalidateListener { |
There was a problem hiding this comment.
would be nicer to have an anonymous inner class so we don't add unnecessary public methods to the LocationLayerPlugin api
There was a problem hiding this comment.
OnCameraMoveInvalidateListener is package private, I don't see the issue here?
There was a problem hiding this comment.
@cammace When implementing an interface we are unnecessary exposing LocationLayerPlugin#onInvalidateCameraMove. Making it an anonymous inner class hides that method.
LukasPaczos
left a comment
LukasPaczos
left a comment
There was a problem hiding this comment.
We need to call onCameraMoveInvalidateListener.onInvalidateCameraMove(); for LocationLayerCamera#setBearing as well.
Additionally, it'd be great to optimize LocationLayerPlugin#onCameraMove not to update when unnecessary, for ex. we don't need to update accuracy radius when zoom has not changed etc. This might help with table overflow issues we've seen recently.
| * @since 0.1.0 | ||
| */ | ||
| public final class LocationLayerPlugin implements LifecycleObserver { | ||
| public final class LocationLayerPlugin implements LifecycleObserver, OnCameraMoveInvalidateListener { |
There was a problem hiding this comment.
@cammace When implementing an interface we are unnecessary exposing LocationLayerPlugin#onInvalidateCameraMove. Making it an anonymous inner class hides that method.
|
I've moved the implementation into a private variable and fixed it not getting invoked inside |
3 participants
Closes #391
cc @danesfeder @LukasPaczos