Skip to content

Conversation

@Guardiola31337
Copy link
Contributor

Warning: com.mapbox.mapboxsdk.plugins.locationlayer.LocationLayerOptions$Builder: can't find referenced class com.google.auto.value.AutoValue$Builder
Warning: com.mapbox.mapboxsdk.plugins.locationlayer.LocationLayerOptions$Builder: can't find referenced class com.google.auto.value.AutoValue$Builder
  • Fixes AutoValue Proguard rules in geojson, locationlayer, offline and places plugins so that builds with Proguard enabled don't fail.

The CI Proguard check (Build release to test ProGuard rules step) was ✅ because of

-keep class com.google.**
-dontwarn com.google.**
which include AutoValue classes (note that com.google.auto.value is included in com.google.**).

We were only taking into account AutoValue classes and not AutoValue$Builder ones 👇

-dontwarn com.google.auto.value.AutoValue

We should remove Mapbox Plugin testapp ProGuard rules after mapbox/mapbox-events-android#109 lands because Proguard rules will be properly managed upstream.

cc @cammace @LukasPaczos @tobrun

@Guardiola31337 Guardiola31337 added build ready for review When your PR has been personally reviewed, its time for an external contributors to approve location-layer-plugin Issues that deal with the location layer module offline-plugin Issues that deal with the offline plugin module places-plugin Issues that deal with the places plugin module labels Apr 9, 2018
@Guardiola31337 Guardiola31337 added this to the location-layer-0.5.0 milestone Apr 9, 2018
@Guardiola31337 Guardiola31337 self-assigned this Apr 9, 2018
@Guardiola31337
Copy link
Contributor Author

cc'ing @danesfeder for visibility

@Guardiola31337 Guardiola31337 merged commit 4c89058 into master Apr 10, 2018
@Guardiola31337 Guardiola31337 deleted the pg-fix-proguard-rules branch April 10, 2018 13:09
@danesfeder danesfeder mentioned this pull request Apr 19, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

location-layer-plugin Issues that deal with the location layer module offline-plugin Issues that deal with the offline plugin module places-plugin Issues that deal with the places plugin module ready for review When your PR has been personally reviewed, its time for an external contributors to approve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants