Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geojson,locationlayer,offlineandplacesplugins so that builds with Proguard enabled don't fail.The CI Proguard check (Build release to test ProGuard rules step) was ✅ because of
mapbox-plugins-android/app/proguard-rules.pro
Lines 3 to 4 in 7a676e4
com.google.auto.valueis included incom.google.**).We were only taking into account
AutoValueclasses and notAutoValue$Builderones 👇mapbox-plugins-android/plugin-locationlayer/proguard-consumer.pro
Line 5 in 7a676e4
We should remove Mapbox Plugin testapp ProGuard rules after mapbox/mapbox-events-android#109 lands because Proguard rules will be properly managed upstream.
cc @cammace @LukasPaczos @tobrun