Skip to content

Manually set the first location update #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LukasPaczos wants to merge 1 commit into from
Closed

Manually set the first location update #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions ...layer/src/main/java/com/mapbox/mapboxsdk/plugins/locationlayer/LocationLayerAnimator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,19 @@ void removeCameraListener(OnCameraAnimationsValuesChangeListener listener) {
cameraListeners.remove(listener);
}

void feedNewLocation(@NonNull Location newLocation, @NonNull CameraPosition currentCameraPosition,
boolean isGpsNorth) {
/**
* Returns whether location has to be updated manually.
*/
boolean feedNewLocation(@NonNull Location newLocation, @NonNull CameraPosition currentCameraPosition,
boolean isGpsNorth) {
if (previousLocation == null) {
previousLocation = newLocation;
locationUpdateTimestamp = SystemClock.elapsedRealtime();
return true;
}

if (invalidUpdateInterval()) {
return;
return false;
}

LatLng previousLayerLatLng = getPreviousLayerLatLng();
Expand All @@ -80,11 +84,17 @@ void feedNewLocation(@NonNull Location newLocation, @NonNull CameraPosition curr
playAllLocationAnimators(getAnimationDuration());

previousLocation = newLocation;

return false;
}

void feedNewCompassBearing(float targetCompassBearing, @NonNull CameraPosition currentCameraPosition) {
/**
* Returns whether compass bearing has to be updated manually.
*/
boolean feedNewCompassBearing(float targetCompassBearing, @NonNull CameraPosition currentCameraPosition) {
if (previousCompassBearing < 0) {
previousCompassBearing = targetCompassBearing;
return true;
}

float previousLayerBearing = getPreviousLayerCompassBearing();
Expand All @@ -94,6 +104,8 @@ void feedNewCompassBearing(float targetCompassBearing, @NonNull CameraPosition c
playCompassAnimators(COMPASS_UPDATE_RATE_MS);

previousCompassBearing = targetCompassBearing;

return false;
}

private final ValueAnimator.AnimatorUpdateListener layerLatLngUpdateListener =
Expand Down Expand Up @@ -251,7 +263,7 @@ private long getAnimationDuration() {
animationDuration = 0;
} else {
animationDuration = (int) ((locationUpdateTimestamp - previousUpdateTimeStamp) * 1.1f)
/*make animation slightly longer*/;
/*make animation slightly longer*/;
}
return animationDuration;
}
Expand Down
11 changes: 9 additions & 2 deletions ...onlayer/src/main/java/com/mapbox/mapboxsdk/plugins/locationlayer/LocationLayerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,12 +505,19 @@ private void updateLocation(final Location location) {
staleStateManager.updateLatestLocationTime();
CameraPosition currentCameraPosition = mapboxMap.getCameraPosition();
boolean isGpsNorth = getCameraMode() == CameraMode.TRACKING_GPS_NORTH;
locationLayerAnimator.feedNewLocation(location, currentCameraPosition, isGpsNorth);
boolean forceLocationUpdate = locationLayerAnimator.feedNewLocation(location, currentCameraPosition, isGpsNorth);
if (forceLocationUpdate) {
locationLayer.onNewLatLngValue(new LatLng(location.getLatitude(), location.getLongitude()));
locationLayer.onNewGpsBearingValue(location.getBearing());
}
locationLayer.updateAccuracyRadius(location);
}

private void updateCompassHeading(float heading) {
locationLayerAnimator.feedNewCompassBearing(heading, mapboxMap.getCameraPosition());
boolean forceCompassUpdate = locationLayerAnimator.feedNewCompassBearing(heading, mapboxMap.getCameraPosition());
if (forceCompassUpdate) {
locationLayer.onNewCompassBearingValue(heading);
}
}

/**
Expand Down