Skip to content

adds transifex #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cammace merged 4 commits into from
Apr 30, 2018
Merged

adds transifex #463

cammace merged 4 commits into from
Apr 30, 2018

Conversation

@cammace
Copy link

@cammace cammace commented Apr 24, 2018

No description provided.

@cammace cammace self-assigned this Apr 24, 2018
@cammace cammace requested a review from 1ec5 April 24, 2018 17:58
1ec5
1ec5 reviewed Apr 25, 2018
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration file looks fine. However, before merging this PR, please take a second look at the Transifex project’s configuration. Specifically, it looks like the list of languages was copied over from another project but none of the translators were (because a new translation team was created). This is an unfortunate situation, because the presence of these languages can dissuade someone from signing up to translate.

Consider either removing all the languages from the new project or assigning the existing Mapbox GL Native team to the new project.

@1ec5
Copy link
Contributor

1ec5 commented Apr 25, 2018

Also, consider adding something to the contributing guide about adding translations, so that we don’t end up getting PRs containing translations that aren’t in Transifex.

@cammace cammace requested review from langsmith and tobrun April 27, 2018 19:45
@cammace cammace added the ready for review When your PR has been personally reviewed, its time for an external contributors to approve label Apr 30, 2018
@cammace cammace merged commit 1781cec into master Apr 30, 2018
@cammace cammace deleted the add-transfex branch April 30, 2018 19:41
@1ec5 1ec5 mentioned this pull request Jun 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobrun tobrun Awaiting requested review from tobrun

2 more reviewers

@1ec5 1ec5 1ec5 left review comments

@langsmith langsmith langsmith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cammace cammace

Labels

ready for review When your PR has been personally reviewed, its time for an external contributors to approve

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cammace @1ec5 @langsmith