Skip to content

enable/disable inside lifecycle methods #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cammace merged 1 commit into from
May 22, 2018
Merged

enable/disable inside lifecycle methods #528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...onlayer/src/main/java/com/mapbox/mapboxsdk/plugins/locationlayer/LocationLayerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ public void removeOnLocationStaleListener(@NonNull OnLocationStaleListener liste
@RequiresPermission(anyOf = {ACCESS_FINE_LOCATION, ACCESS_COARSE_LOCATION})
@OnLifecycleEvent(Lifecycle.Event.ON_START)
public void onStart() {
onLocationLayerStart();
enableLocationLayerPlugin();
if (isEnabled) {
mapView.addOnMapChangedListener(onMapChangedListener);
}
Expand All @@ -429,7 +429,7 @@ public void onStart() {
*/
@OnLifecycleEvent(Lifecycle.Event.ON_STOP)
public void onStop() {
onLocationLayerStop();
disableLocationLayerPlugin();
mapView.removeOnMapChangedListener(onMapChangedListener);
}

Expand Down Expand Up @@ -515,7 +515,7 @@ private void updateMapWithOptions(final LocationLayerOptions options) {
* @since 0.1.0
*/
private void updateLocation(final Location location) {
if (location == null) {
if (location == null || !isEnabled) {
return;
}
staleStateManager.updateLatestLocationTime();
Expand Down