Harden state and style changes #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 29, 2018 17:51
LukasPaczos
added
the
location-layer-plugin
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #515.
Reverts the regression introduced in #528 which would re-enable location layer plugin even if disabled when the lifecycle is stopped and started again. This PR adds another solution to this issue with 965b6d9.
Cleans up source addition checks that became obsolete with #516.
Fixes crash that would occur when the plugin is disabled, the lifecycle is stopped then started and the style is changed, which would result in layers and sources not being initialized leading to a native
null pointer dereferenceexception.