Skip to content

Conversation

@langsmith
Copy link
Contributor

@tobrun @LukasPaczos

Resolves #529 by fixing the floating marker in the place picker functionality of the places plugin. In my opinion, this bug renders the picker essentially unusable.

If you share my slight concern thatmapView.getY() / 2 isn't the most performant fix, given that it happens every time that onCameraIdle() fires, I'm happy to hear other ideas for fixing.

ezgif com-optimize

@langsmith langsmith added bug A bug is found inside the code base and should be immediately brought to attention ASAP places-plugin Issues that deal with the places plugin module labels Jul 18, 2018
@langsmith langsmith requested review from LukasPaczos and tobrun and removed request for LukasPaczos and tobrun July 18, 2018 05:39
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @langsmith 🚀

public void onCameraIdle() {
Timber.v("Map camera is now idling.");
markerImage.animate().yBy(Math.abs(markerImage.getTranslationY()))
markerImage.animate().translationY(Math.abs(mapView.getY() / 2))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, as the markerImage has view constraints to its parent, just markerImage.animate().translationY(0) should be enough here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that works. Fixed

ezgif com-optimize

@langsmith langsmith merged commit 078b169 into master Jul 18, 2018
@langsmith langsmith deleted the ls-floating-places-picker-marker-fix branch July 18, 2018 15:27
@langsmith
Copy link
Contributor Author

Any chance we can do a new release of the Places Plugin in the next couple of weeks @LukasPaczos @zugaldia ? A release hasn't gone out since this pr was merged into master, so in my opinion, the place picker functionality continues to be broken/useless for devs who are using the latest stable version. They'll still see #529 in their projects. Or are we fine with advising folks to use 0.6.0-SNAPSHOT for now?

cc @riastrad in case you get any future inbound questions about this.

@zugaldia
Copy link
Member

I agree with @langsmith that the plugin is due for a new release.

@LukasPaczos @osana can you tandem to release a new version of the places plugin? I'll defer to you on timing, the upcoming frappe release is a good opportunity to refresh the plugins but I can also see value publishing it earlier to include the fix mentioned above.

@bradjonesca
Copy link

@zugaldia could you explain or direct me to any information about the "frappe" release? I had not heard of it before now, thank-you

@zugaldia
Copy link
Member

@bradjonesca my bad, I should have provided a better explanation :) frappe is the codename for the upcoming Maps SDK release, which on Android is 6.5.0. We just released 6.5.0-alpha.2 and we expect a final release in the next few weeks (we name our Maps SDK release after drinks, you can see previous names in the release-* branch names in http://github.com/mapbox/mapbox-gl-native).

@LukasPaczos LukasPaczos mentioned this pull request Sep 12, 2018
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A bug is found inside the code base and should be immediately brought to attention ASAP places-plugin Issues that deal with the places plugin module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marker icon is drifting away

4 participants