-
Notifications
You must be signed in to change notification settings - Fork 117
Fix for disappearing places picker marker #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LukasPaczos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @langsmith 🚀
| public void onCameraIdle() { | ||
| Timber.v("Map camera is now idling."); | ||
| markerImage.animate().yBy(Math.abs(markerImage.getTranslationY())) | ||
| markerImage.animate().translationY(Math.abs(mapView.getY() / 2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, as the markerImage has view constraints to its parent, just markerImage.animate().translationY(0) should be enough here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Any chance we can do a new release of the Places Plugin in the next couple of weeks @LukasPaczos @zugaldia ? A release hasn't gone out since this pr was merged into cc @riastrad in case you get any future inbound questions about this. |
|
I agree with @langsmith that the plugin is due for a new release. @LukasPaczos @osana can you tandem to release a new version of the places plugin? I'll defer to you on timing, the upcoming |
|
@zugaldia could you explain or direct me to any information about the "frappe" release? I had not heard of it before now, thank-you |
|
@bradjonesca my bad, I should have provided a better explanation :) |

@tobrun @LukasPaczos
Resolves #529 by fixing the floating marker in the place picker functionality of the places plugin. In my opinion, this bug renders the picker essentially unusable.
If you share my slight concern that
mapView.getY() / 2isn't the most performant fix, given that it happens every time thatonCameraIdle()fires, I'm happy to hear other ideas for fixing.