Skip to content

Conversation

@snkashis
Copy link
Contributor

Our logs are getting littered with these below error messages for regional/country variants after a recent APK update, so I figured I would give it a try so even when exact matches are not present, this plugin is valuable.

Couldn't match Locale español (Colombia) to a MapLocale
Couldn't match Locale español (Estados Unidos) to a MapLocale
Couldn't match Locale español (Honduras) to a MapLocale
Couldn't match Locale español (Argentina) to a MapLocale
Couldn't match Locale español (México) to a MapLocale

@tobrun
Copy link
Member

tobrun commented Jan 21, 2019

@snkashis thank you for contributing!
@LukasPaczos would you be able to review this?

@LukasPaczos
Copy link
Contributor

The initial implementation looks great @snkashis, thanks a lot for the contribution! I'm going to go ahead and cherry pick the commit to make the CI run and fix the formatting and test app examples.

@LukasPaczos
Copy link
Contributor

Closing in favor of #828, thanks again @snkashis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants