Skip to content

Adding ability to set status bar color in places plugin search UI #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
langsmith merged 1 commit into from
May 22, 2019
Merged

Adding ability to set status bar color in places plugin search UI #962

langsmith merged 1 commit into from
May 22, 2019

Conversation

@langsmith
Copy link
Contributor

@langsmith langsmith commented May 22, 2019

Resolves #954 by adding a PlaceOptions.Builder method to set the color of the status bar. If no color is passed through, the default color is black. This gives developers the ability to further customize the places plugin UI.

cc @Firzen7, who opened #954

ezgif com-resize (1)

@langsmith langsmith added ready for review When your PR has been personally reviewed, its time for an external contributors to approve places-plugin Issues that deal with the places plugin module labels May 22, 2019
@langsmith langsmith requested review from LukasPaczos and tobrun May 22, 2019 05:15
@langsmith langsmith self-assigned this May 22, 2019
@langsmith langsmith force-pushed the ls-fixing-black-toolbar-in-autocomplete-places-plugin branch from d74d35b to 8b89d0e Compare May 22, 2019 05:16
tobrun
tobrun approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, minor nit

@langsmith langsmith force-pushed the ls-fixing-black-toolbar-in-autocomplete-places-plugin branch from 8b89d0e to c53d8e5 Compare May 22, 2019 13:15
@langsmith langsmith merged commit a924272 into master May 22, 2019
@langsmith langsmith deleted the ls-fixing-black-toolbar-in-autocomplete-places-plugin branch May 22, 2019 13:25
@langsmith langsmith mentioned this pull request May 22, 2019
Closed
@langsmith langsmith mentioned this pull request Jun 11, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobrun tobrun tobrun approved these changes

@LukasPaczos LukasPaczos Awaiting requested review from LukasPaczos

Assignees

@langsmith langsmith

Labels

places-plugin Issues that deal with the places plugin module ready for review When your PR has been personally reviewed, its time for an external contributors to approve

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PlaceAutocomplete does not set toolbarColor

2 participants

@langsmith @tobrun