Skip to content

Added check for null latLng in PlacePickerActivity makeReverseGeocodingSearch() #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
langsmith merged 1 commit into from
May 22, 2019
Merged

Added check for null latLng in PlacePickerActivity makeReverseGeocodingSearch() #964

langsmith merged 1 commit into from
May 22, 2019

Conversation

@langsmith
Copy link
Contributor

@langsmith langsmith commented May 22, 2019

Resolves #817 by checking whether latLng from LatLng latLng = mapboxMap.getCameraPosition().target; is null. Null latLng seemed to be the issue reported in #817 .

@langsmith langsmith added ready for review When your PR has been personally reviewed, its time for an external contributors to approve places-plugin Issues that deal with the places plugin module labels May 22, 2019
@langsmith langsmith requested a review from LukasPaczos May 22, 2019 20:15
@langsmith langsmith self-assigned this May 22, 2019
@langsmith
Copy link
Contributor Author

langsmith commented May 22, 2019

Not sure whether anything else is needed in this pr. Throw some sort of Exception message? Or no need?

@langsmith langsmith requested a review from tobrun May 22, 2019 20:24
@langsmith langsmith merged commit b84d413 into master May 22, 2019
@langsmith langsmith deleted the ls-getLongitude-npe-bug-fix branch May 22, 2019 21:21
@langsmith langsmith mentioned this pull request May 22, 2019
Closed
@langsmith langsmith mentioned this pull request Jun 11, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobrun tobrun tobrun approved these changes

@LukasPaczos LukasPaczos Awaiting requested review from LukasPaczos

Assignees

@langsmith langsmith

Labels

places-plugin Issues that deal with the places plugin module ready for review When your PR has been personally reviewed, its time for an external contributors to approve

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NullPointerException in PlacePickerActivity

2 participants

@langsmith @tobrun