Skip to content

Conversation

@langsmith
Copy link
Contributor

@langsmith langsmith commented May 22, 2019

This pr resolves #857 by adding a PlacePickerOptions.Builder() method to includeReverseGeocode(boolean). If false is passed through, the bottom sheet is hidden and no geocoding call is made (saving developer $). If true, bottom sheet is shown with reverse geocoding information displayed.

cc @kbauhaus as fyi about search-related functionality.

ezgif com-resize (3)

@langsmith langsmith added enhancement feature places-plugin Issues that deal with the places plugin module labels May 22, 2019
@langsmith langsmith self-assigned this May 22, 2019
@langsmith
Copy link
Contributor Author

cc @androideveloper , who asked about this in #857

@langsmith langsmith force-pushed the ls-adding-placepicker-without-geocoding-functionality branch from 5ec4620 to acf7a5d Compare May 22, 2019 23:30
@langsmith langsmith marked this pull request as ready for review May 22, 2019 23:32
@langsmith langsmith requested review from LukasPaczos and tobrun May 22, 2019 23:32
@langsmith
Copy link
Contributor Author

Also meant to note that if false is passed through, PlacePicker.getLastCameraPosition(data) should be used to get the CameraPosition that represents the picked location. This is done in the test app's PickerLauncherActivity:

} else {
val cameraPosition = PlacePicker.getLastCameraPosition(data)
Toast.makeText(this, cameraPosition.target.toString(), Toast.LENGTH_LONG).show()
}

@langsmith langsmith added the ready for review When your PR has been personally reviewed, its time for an external contributors to approve label May 22, 2019
@langsmith langsmith merged commit ea583cf into master May 23, 2019
@langsmith langsmith deleted the ls-adding-placepicker-without-geocoding-functionality branch May 23, 2019 12:44
@androideveloper
Copy link

androideveloper commented Jun 2, 2019

Great, Thanks! Btw, is there a way to enable "My location" button in Place Picker page that zooms to user current location?
googleMapsScreen1-576x1024

@androideveloper
Copy link

cc @karapetyanmery, take a look

@langsmith
Copy link
Contributor Author

@androideveloper ,

is there a way to enable "My location" button in Place Picker page that zooms to user current location

There currently isn't a way to enable this, but it wouldn't be too hard to add this. I've created #973 to track your request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature places-plugin Issues that deal with the places plugin module ready for review When your PR has been personally reviewed, its time for an external contributors to approve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Place picker without geocoding option

3 participants