Skip to content

Conversation

@langsmith
Copy link
Contributor

Resolves #818 by combining the Place Picker and geocoding autocomplete UI functionalities together. Several folks in #818 have expressed interest in having this.

@mapbox/maps-android , what do you think about the code and UI so far?

ezgif com-resize (6)

@langsmith langsmith added enhancement question For any code questions places-plugin Issues that deal with the places plugin module labels May 29, 2019
@LukasPaczos
Copy link
Contributor

Looks cool 👍 I'd add the searchbox to the toolbar and collapse the search results list when a record is clicked.

@langsmith langsmith force-pushed the ls-combining-place-picker-and-address-autocomplete branch 2 times, most recently from 75d3ecc to c4af7df Compare June 7, 2019 23:33
@langsmith
Copy link
Contributor Author

Made a little progress on this today.

.includeSearch(false) leads to the instructional Choose a location toolbar text:
ezgif com-resize

.includeSearch(true) places the autocomplete search UI widget in the toolbar area:

ezgif com-resize (1)

The next TODO is hiding the search UI dropdown when a location is selected.

@langsmith langsmith force-pushed the ls-combining-place-picker-and-address-autocomplete branch 7 times, most recently from a551d48 to 763cba0 Compare June 16, 2019 00:23
@langsmith langsmith force-pushed the ls-combining-place-picker-and-address-autocomplete branch 2 times, most recently from dc7b8da to 45b0cf0 Compare June 20, 2019 01:17
@langsmith langsmith force-pushed the ls-combining-place-picker-and-address-autocomplete branch from 45b0cf0 to d314fd1 Compare June 26, 2019 20:16
@percula
Copy link

percula commented Jul 22, 2019

This is great! Any chance of this being merged by the 29th, when Google officially deprecates their PlacePicker?

@langsmith langsmith force-pushed the ls-combining-place-picker-and-address-autocomplete branch 6 times, most recently from 37c448d to 1baceb0 Compare August 2, 2019 22:57
@langsmith langsmith marked this pull request as ready for review August 2, 2019 23:07
@langsmith langsmith requested a review from LukasPaczos August 2, 2019 23:10
@langsmith langsmith removed the question For any code questions label Aug 2, 2019
@langsmith
Copy link
Contributor Author

Ok, things are finally behaving. This is ready for some more review.

The results drop-down list appears (i.e. the SearchView height is lengthened) when:

  • typing occurs in the search UI EditText. Can be either the first text entered in the EditText or typing to adjust existing text.
  • focus switches on to the search UI EditText. This happens when someone taps on the EditText for the first time and the cursor starts blinking in the EditText field.

The results drop-down list disappears (i.e. the SearchView height is shortened) when:

  • it's showing and the map is tapped on.
  • a location in the results list is tapped on.
  • there's text in the search UI EditText and then the X clear button is tapped.

ezgif com-resize (9)

ezgif com-resize (6)

ezgif com-resize (7)

@langsmith langsmith added the ready for review When your PR has been personally reviewed, its time for an external contributors to approve label Aug 2, 2019
@langsmith langsmith force-pushed the ls-combining-place-picker-and-address-autocomplete branch from 249497f to dea8e0f Compare August 12, 2019 22:53
@langsmith langsmith force-pushed the ls-combining-place-picker-and-address-autocomplete branch 8 times, most recently from 55f5a7c to ba7fb45 Compare September 15, 2019 16:22
@langsmith
Copy link
Contributor Author

Ok, I fixed FAB behavior. This is ready for another round of review when you've got a chance and are in the mood.

@langsmith langsmith force-pushed the ls-combining-place-picker-and-address-autocomplete branch from ba7fb45 to d8501c4 Compare September 15, 2019 16:25
@langsmith
Copy link
Contributor Author

ezgif com-resize
ezgif com-resize (1)
ezgif com-resize (2)

@langsmith langsmith force-pushed the ls-combining-place-picker-and-address-autocomplete branch from d8501c4 to 127ec8a Compare September 16, 2019 05:48
@zugaldia
Copy link
Member

/cc: @vng

@vng
Copy link

vng commented Sep 17, 2019

/cc: @alexander-kulikovskii

@LukasPaczos
Copy link
Contributor

ezgif com-video-to-gif
When the bottom sheet is hidden, the margin on the FAB is 0, while it should be 16dp or so. Also, when the bottom sheet is extended, the attribution view ((i) icon) does not match the padding of the logo.

ezgif com-video-to-gif (1)
Not sure what material guidelines are, but this slight movement of both fabs up and down does not look right. More of a nit pick this one, we can ship regardless.

ezgif com-video-to-gif (2)
There seems to be a race condition when extending the keyboard on view inflation that doesn't adjust the bottom sheets padding/margin correctly. Probably the keyboard measurement is performed too soon? Ultimately, do we even need the sheet to be adjusted for the keyboard?

ezgif com-video-to-gif (3)
If there's no search history and the keyboard is closed, the search view is still extended with an empty background. The search box generally doesn't lose focus on back press, while it probably should.

round_edges
Because the toolbar in search mode has round edges, it creates an unnatural gap between the status bar and toolbar.

@stale
Copy link

stale bot commented Dec 8, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the archived Archived by Stale bot. label Dec 8, 2019
@stale
Copy link

stale bot commented Dec 8, 2019

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this Dec 8, 2019
@langsmith langsmith reopened this Dec 9, 2019
@stale stale bot removed the archived Archived by Stale bot. label Dec 9, 2019
@stale
Copy link

stale bot commented Feb 7, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the archived Archived by Stale bot. label Feb 7, 2020
@stale
Copy link

stale bot commented Feb 8, 2020

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

archived Archived by Stale bot. enhancement places-plugin Issues that deal with the places plugin module ready for review When your PR has been personally reviewed, its time for an external contributors to approve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Widget combining the place picker and the address autocompleter

5 participants