-
Notifications
You must be signed in to change notification settings - Fork 117
Combining the place picker and the geocode UI address autocomplete #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combining the place picker and the geocode UI address autocomplete #968
Conversation
|
Looks cool 👍 I'd add the searchbox to the toolbar and collapse the search results list when a record is clicked. |
75d3ecc to
c4af7df
Compare
a551d48 to
763cba0
Compare
dc7b8da to
45b0cf0
Compare
45b0cf0 to
d314fd1
Compare
|
This is great! Any chance of this being merged by the 29th, when Google officially deprecates their PlacePicker? |
37c448d to
1baceb0
Compare
|
Ok, things are finally behaving. This is ready for some more review. The results drop-down list appears (i.e. the
The results drop-down list disappears (i.e. the
|
249497f to
dea8e0f
Compare
55f5a7c to
ba7fb45
Compare
|
Ok, I fixed FAB behavior. This is ready for another round of review when you've got a chance and are in the mood. |
ba7fb45 to
d8501c4
Compare
d8501c4 to
127ec8a
Compare
|
/cc: @vng |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |













Resolves #818 by combining the Place Picker and geocoding autocomplete UI functionalities together. Several folks in #818 have expressed interest in having this.
@mapbox/maps-android , what do you think about the code and UI so far?