Adding Portuguese language support to Localization Plugin #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langsmith
added
the
ready for review
tobrun
approved these changes
Jun 6, 2019
|
Really appreciated. Thank you guys! (: |
Contributor
Author
|
Next release would be |
This was referenced Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves @leocarona 's #978. The Localization Plugin for Android didn't have support for Portuguese (Portugal/Brazil). This pr adds supports for it.
To test this pr, install this repo's test app on
master. Go to the Localization Plugin activity and switch your phone device into Portugal or Brazil Portuguese. You'll see the map doesn't switch to Portuguese.Then switch to this pr's branch and reinstall this app. The map does switch to Portuguese for Portugal and Brazil.