Added user location button to Places Plugin's PlacePickerActivity #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
reviewed
Jun 20, 2019
...-places/src/main/java/com/mapbox/mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java
Outdated
Show resolved
Hide resolved
...-places/src/main/java/com/mapbox/mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java
Outdated
Show resolved
Hide resolved
...-places/src/main/java/com/mapbox/mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java
Show resolved
Hide resolved
...-places/src/main/java/com/mapbox/mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java
Outdated
Show resolved
Hide resolved
LukasPaczos
approved these changes
Jun 21, 2019
langsmith
force-pushed
the
ls-adding-device-location-button-to-place-picker
branch
from
6ff8c7b to
cf006ba
Compare
|
Thanks! |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #973 by adding a device location Floating Action Button to the
PlacePickerActivity. The button is hooked into the Maps SDK'sLocationComponent, so this pr also adds theLocationComponentsetup to thePlacePickerActivity.This pr also adds a
includeDeviceLocationButton()option toPlacePickerOptions.java. If theincludeDeviceLocationButton()method isn't used, the default is to not include the button in thePlacePickerActivityUI.cc @androideveloper, who requested this.