Skip to content

Location provider#12

Merged
david-rhodes merged 7 commits intodevelopfrom
location-provider
Apr 17, 2017
Merged

Location provider#12
david-rhodes merged 7 commits intodevelopfrom
location-provider

Conversation

@david-rhodes
Copy link
Copy Markdown

Added a new example scene LocationProvider.unity and relevant LocationProvider scripts meant to show how to :

  • Build a map for your current (device) location
  • Update a virtual player's position and rotation based on a real or mock location and heading
  • Use mock location providers to test in the Unity editor
  • Convert between unity world space<—>earth space (latitude, longitude)

Added relevant in-line documentation and notes here: https://mapbox.github.io/mapbox-unity-sdk/docs/03-examples.html#locationprovider.

This was a common request from users and most of the work was already done for MapboxGO.

@david-rhodes david-rhodes requested review from MateoV, brnkhy and isiyu April 14, 2017 21:50
Copy link
Copy Markdown

@isiyu isiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @david-rhodes! - tested locally. Approving, just have thoughts on documentation - that don't block merging the PR.

The example description took some close reading to figure out what was happening. This example deals with things in action. I think this example would benefit from a vid cap when we start doing those, or some gifs.
https://mapbox.github.io/mapbox-unity-sdk/docs/03-examples.html#locationprovider

Inline code examples would be helpful for the location provider library.
https://mapbox.github.io/mapbox-unity-sdk/api/unity/Mapbox.Unity.Location.DeviceLocationProvider.html

@david-rhodes david-rhodes merged commit 5498f25 into develop Apr 17, 2017
@david-rhodes david-rhodes deleted the location-provider branch April 17, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants