Location provider#12
Merged
david-rhodes merged 7 commits intodevelopfrom Apr 17, 2017
Merged
Conversation
added 7 commits
April 13, 2017 10:33
Fixing compile errors and update LocationProvider with latest conversion and Vector2 changes. Sample player positioned with location provider.
Updated inline documentation.
isiyu
approved these changes
Apr 17, 2017
isiyu
left a comment
There was a problem hiding this comment.
Looks good @david-rhodes! - tested locally. Approving, just have thoughts on documentation - that don't block merging the PR.
The example description took some close reading to figure out what was happening. This example deals with things in action. I think this example would benefit from a vid cap when we start doing those, or some gifs.
https://mapbox.github.io/mapbox-unity-sdk/docs/03-examples.html#locationprovider
Inline code examples would be helpful for the location provider library.
https://mapbox.github.io/mapbox-unity-sdk/api/unity/Mapbox.Unity.Location.DeviceLocationProvider.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new example scene
LocationProvider.unityand relevant LocationProvider scripts meant to show how to :Added relevant in-line documentation and notes here: https://mapbox.github.io/mapbox-unity-sdk/docs/03-examples.html#locationprovider.
This was a common request from users and most of the work was already done for MapboxGO.