Skip to content

fix vertex/triangle mismatch#3

Merged
david-rhodes merged 1 commit intodevelopfrom
polygonModifierFix
Mar 31, 2017
Merged

fix vertex/triangle mismatch#3
david-rhodes merged 1 commit intodevelopfrom
polygonModifierFix

Conversation

@brnkhy
Copy link
Copy Markdown
Contributor

@brnkhy brnkhy commented Mar 31, 2017

triangulation library occasionally adds extra vertices to have a good result and we wasn't checking that before which caused vertex count / tri index mismatch.

@brnkhy brnkhy requested a review from david-rhodes March 31, 2017 13:45
@david-rhodes
Copy link
Copy Markdown

@brnkhy

  • In what situations do these extra vertices get created? Randomly? Specific problem-cases?
  • What does the final geometry look like without extra vertices?
  • Can we tell the triangulation library to maintain original vert count?

@brnkhy
Copy link
Copy Markdown
Contributor Author

brnkhy commented Mar 31, 2017

@david-rhodes

  • If I remember correctly I wasn't able to understand why/when it happens.
  • No way to check that out as triangulation indexes uses that extra vertice and cant visualize without that.
  • Documentation is horrible. there's a check which I thought would have fix this; Behavior.Quality = false; but did nothing either. I gave up on that search afterwards. We can look more into that once we have working copy on master though

@david-rhodes
Copy link
Copy Markdown

Ok, let's try to remember to revisit later.

Copy link
Copy Markdown

@david-rhodes david-rhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples still work and confirmed the fix works.

@david-rhodes david-rhodes merged commit da957a6 into develop Mar 31, 2017
@david-rhodes david-rhodes deleted the polygonModifierFix branch March 31, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants