Skip to content

Terrain/Image factory editors and basic refactors#4

Merged
david-rhodes merged 5 commits intodevelopfrom
factoryRefactor
Apr 3, 2017
Merged

Terrain/Image factory editors and basic refactors#4
david-rhodes merged 5 commits intodevelopfrom
factoryRefactor

Conversation

@brnkhy
Copy link
Copy Markdown
Contributor

@brnkhy brnkhy commented Mar 31, 2017

add terrain and mapimage factory editors
add normals list to mesh data class
add mesh renderer and filter caches in unity tile
rename SatelliteDataChangedEvent to ImageDataChangedEvent

add normals list to mesh data class
add mesh renderer and filter caches in unity tile
rename SatelliteDataChangedEvent to ImageDataChangedEvent
@brnkhy brnkhy requested a review from david-rhodes March 31, 2017 16:57
…toryRefactor

# Conflicts:
#	sdkproject/Assets/Mapbox/Core/Unity/MeshGeneration/Data/MeshData.cs
#	sdkproject/Assets/Mapbox/Core/Unity/MeshGeneration/Factories/TerrainFactory.cs

Due to the recent Vector2d merge, TerrainFactory now has compile errors!
@david-rhodes
Copy link
Copy Markdown

@brnkhy Merged develop in (with Vector2d) and there are now conflicts in TerrainFactory because of Rect changes. Please fix.

@david-rhodes
Copy link
Copy Markdown

@brnkhy Non-flat terrain does not appear to be working correctly in the slippy example.

@brnkhy
Copy link
Copy Markdown
Contributor Author

brnkhy commented Apr 1, 2017

@david-rhodes this should be fixed, it was a silly error I did while converting rect calls to rectd calls.

@david-rhodes david-rhodes merged commit f550f77 into develop Apr 3, 2017
@david-rhodes david-rhodes deleted the factoryRefactor branch April 3, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants