Skip to content

fix mesh factory editor script null ref errors and not saving on change#41

Merged
david-rhodes merged 4 commits intodevelopfrom
meshFactoryEditorFix
May 1, 2017
Merged

fix mesh factory editor script null ref errors and not saving on change#41
david-rhodes merged 4 commits intodevelopfrom
meshFactoryEditorFix

Conversation

@brnkhy
Copy link
Copy Markdown
Contributor

@brnkhy brnkhy commented May 1, 2017

No description provided.

@brnkhy brnkhy requested a review from david-rhodes May 1, 2017 16:38
@david-rhodes
Copy link
Copy Markdown

@brnkhy When creating a new mesh factory asset, the inspector does not show anything. You cannot assign visualizers or anything.

@brnkhy
Copy link
Copy Markdown
Contributor Author

brnkhy commented May 1, 2017

@david-rhodes Initializing the vsualizers list in onenable now but I'm not sure if it's before the deserialization (has to be). tried a few cases and seems like ti's working. would be great if you can try a few times as well.

Copy link
Copy Markdown

@david-rhodes david-rhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@david-rhodes david-rhodes merged commit 134136d into develop May 1, 2017
@david-rhodes david-rhodes deleted the meshFactoryEditorFix branch May 1, 2017 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants