Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

Update changelog for 0.13.0 release #250

Merged
yuryybk merged 11 commits into from
Jun 30, 2020
Merged

Update changelog for 0.13.0 release #250

yuryybk merged 11 commits into from
Jun 30, 2020

Conversation

@yuryybk
Copy link
Contributor

@yuryybk yuryybk commented Jun 23, 2020

No description provided.

@yuryybk yuryybk added P0 Blocker or must-have Android labels Jun 23, 2020
@yuryybk yuryybk self-assigned this Jun 23, 2020
@yuryybk yuryybk requested review from kiryldz and yunikkk June 23, 2020 13:47
@yuryybk
Copy link
Contributor Author

yuryybk commented Jun 23, 2020

@yunikkk @kiryldz please compare with https://github.com/mapbox/mapbox-vision/blob/release/0.13.0/docs/changelog.md if I've described changelog correctly

kiryldz
kiryldz reviewed Jun 23, 2020
View reviewed changes
kiryldz
kiryldz reviewed Jun 23, 2020
View reviewed changes
@kiryldz
Copy link
Contributor

kiryldz commented Jun 23, 2020 •
edited
Loading

@yuryybk, where is Integrated LaneDetection mode for VisionView BTW?
As well as
Deprecate VisionArEventsListener.onArCameraUpdated(ArCamera) method
Extend Camera class returned by VisionEventsListener.onCameraUpdated

yunikkk
yunikkk reviewed Jun 23, 2020
View reviewed changes
yunikkk
yunikkk reviewed Jun 23, 2020
View reviewed changes
@yuryybk yuryybk requested review from kiryldz and yunikkk June 23, 2020 16:04
@yuryybk
Copy link
Contributor Author

yuryybk commented Jun 23, 2020

@yuryybk, where is Integrated LaneDetection mode for VisionView BTW?
As well as
Deprecate VisionArEventsListener.onArCameraUpdated(ArCamera) method
Extend Camera class returned by VisionEventsListener.onCameraUpdated

Added to changelog

yunikkk
yunikkk reviewed Jun 23, 2020
View reviewed changes
yunikkk
yunikkk reviewed Jun 23, 2020
View reviewed changes
@chezzdev
Copy link

chezzdev commented Jun 23, 2020

Have we formed the general changelog first?

@yuryybk
Copy link
Contributor Author

yuryybk commented Jun 24, 2020 •
edited
Loading

@chezzdev not sure exactly about the process, I've built it from the mapbox-vision/docs/changelog.md.
I've found an issue from the previous changelog, https://github.com/mapbox/mapbox-vision/issues/2314, we need to discuss the correct flow.

@yuryybk yuryybk requested a review from yunikkk June 24, 2020 11:05
kiryldz
kiryldz reviewed Jun 24, 2020
View reviewed changes
@yuryybk yuryybk requested review from chezzdev and kiryldz June 24, 2020 12:31
@yuryybk
Copy link
Contributor Author

yuryybk commented Jun 24, 2020

@chezzdev @yunikkk @kiryldz
I've got changelog with the help of Dersim and tried to sort with Private\Public on Android
Please check changelog here and autogenerated

kiryldz
kiryldz approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@kiryldz kiryldz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side.

yunikkk
yunikkk reviewed Jun 24, 2020
View reviewed changes
yunikkk
yunikkk reviewed Jun 24, 2020
View reviewed changes
@yuryybk yuryybk requested a review from yunikkk June 24, 2020 13:03
@yuryybk
Copy link
Contributor Author

yuryybk commented Jun 25, 2020

Do not merge until we publish a new version of SDK

@yuryybk yuryybk requested review from kiryldz and yunikkk June 30, 2020 10:07
kiryldz
kiryldz reviewed Jun 30, 2020
View reviewed changes
kiryldz
kiryldz approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@kiryldz kiryldz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit

yuryybk and others added 2 commits June 30, 2020 13:10
@yuryybk @kiryldz
Update CHANGELOG.md
4e8830b 
Co-authored-by: Kiryl Dzehtsiarenka <kiryl.dzehtsiarenka@mapbox.com>
@yuryybk
Revert "Update CHANGELOG.md"
aa65db2 
This reverts commit 4e8830b.
@yuryybk yuryybk merged commit 47edb8b into dev Jun 30, 2020
@yuryybk yuryybk deleted the ybk_update_changelog branch June 30, 2020 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@kiryldz kiryldz kiryldz approved these changes

@yunikkk yunikkk yunikkk approved these changes

@chezzdev chezzdev chezzdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yuryybk yuryybk

Labels

Android DO NOT MERGE P0 Blocker or must-have

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yuryybk @kiryldz @chezzdev @yunikkk