Conversation
|
I'm unable to trigger a build for this 🤔 getting the following error locally when running @springmeyer ever seen this? |
|
The .travis.yml file was empty 🤦♂️ - trigger works now |
| function mason_compile { | ||
| mkdir -p ${MASON_PREFIX}/include/ | ||
| cp -r include/mapbox ${MASON_PREFIX}/include/mapbox | ||
| cp -r include/boost ${MASON_PREFIX}/include/boost |
There was a problem hiding this comment.
Unrelated to this PR/package version, but want to highlight that this cp -r include/boost ${MASON_PREFIX}/include/boost is a bit freaky. I added this in the first PR for the mason package and it relates to how spatial-algorithms vendors some boost geometry related "extension" headers that @artemp uses in spatial-algorithms but which don't (yet) get distributed with the normal boost install. Highlighting this because it is unclear how this will play with mason linking into ./mason_packages/.link/include/boost when both the official boost package and spatial-algorithms are installed. Will one win out over the other, or will their unique paths both be linked by file. /cc @millzpaugh because this will be an important stress test for mason-js linking: to ensure this works.
|
Looks good @mapsam - please merge once you are ready. |
|
Note: the one failure on travis for this branch is unrelated to this branches changes and rather yet another issue of network fail on travis: #516 (comment) |
2 participants
Dev version of spatial-algorithms mapbox/spatial-algorithms@cdda174
cc @mapbox/core-tech