Merged
Conversation
added 8 commits
November 27, 2019 20:54
…l operator operator Q
Contributor
|
@springmeyer Could the Node 12 support be done independently of the #163 work? I'm asking because it seems like #163 doesn't have a super clear path forward, while supporting Node 12 (and dropping EOL'd Node versions) seems narrowly-scoped enough to be done independently. |
Contributor
Author
Contributor
Author
|
Update: Going to plan to work on node v12 soon that does not bundle any other potential breaking changes. So I'll revive and revisit this PR in the coming month or so. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on top of #163, this adds Node v12 support.
Closes #159
/cc @mapbox/map-design-team @mapbox/static-apis @mapbox/maps-api