Skip to content

Fix broken types in index.d.ts #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheindel merged 2 commits into from
Aug 23, 2023
Merged

Fix broken types in index.d.ts #105

sheindel merged 2 commits into from
Aug 23, 2023

Conversation

@rooby
Copy link
Contributor

@rooby rooby commented Aug 23, 2023

sheindel
sheindel suggested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@sheindel sheindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but options and stream args in zip both need marked as optional as well

@rooby
Copy link
Contributor Author

rooby commented Aug 23, 2023

Thanks for the quick review @sheindel .
I have made those parameters optional now.

@rooby rooby requested a review from sheindel August 23, 2023 07:29
@sheindel sheindel merged commit 8768a97 into mapbox:master Aug 23, 2023
@sheindel
Copy link
Contributor

sheindel commented Aug 23, 2023

Thanks for doing this! I'll try to get mapbox to put out a release tomorrow

@rooby
Copy link
Contributor Author

rooby commented Aug 23, 2023

No problem. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sheindel sheindel sheindel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type errors due to default values in type file Cannot import OGCGeometry enum

2 participants

@rooby @sheindel