Add test case for missing error code addition #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
EMAPNIKeror code within thesource.profilemethod so that errors can be handled properly in mapbox-upload validate (refs https://github.com/mapbox/mapbox-upload-validate/blob/master/lib/validators/tm2z.js#L19).NOTE: I think this is a stopgap to a deeper mapnik bug. The style added here was valid in mapnik 3.4.17, but invalid in 3.5.6 because of a
Tile does not existerror. This smells like something else is afoot, and while this PR fixes the missing code and should be merged, we should solve the underlying issue asap.cc/ @GretaCB @flippmoke @springmeyer @mapsam