Fix "incomplete" test fixture to be valid gzip of incomplete data #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zlib module in Node 5 now throws if it sees an unexpected end of file, so the current test that the tilelive decode correctly throws on incomplete JSON currently fails because the unzip part of the pipeline is throwing instead.
Contributor
Author
|
For the record, the upstream change that caused this is nodejs/node#2595. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zlib module in Node 5 now throws if it sees an unexpected end of
file, so the current test that the tilelive decode correctly throws
on incomplete JSON currently fails because the unzip part of the
pipeline is throwing instead.