Skip to content

Fix glyph clipping at the bottom/2 #42#43

Merged
mourner merged 1 commit intomapbox:mainfrom
boris-ulyanov:main
Feb 1, 2022
Merged

Fix glyph clipping at the bottom/2 #42#43
mourner merged 1 commit intomapbox:mainfrom
boris-ulyanov:main

Conversation

@boris-ulyanov
Copy link
Contributor

@boris-ulyanov boris-ulyanov commented Jan 7, 2022

No description provided.

@boris-ulyanov
Copy link
Contributor Author

boris-ulyanov commented Jan 16, 2022

Example for illustration

Symbol = (all parameters are default)

actualBoundingBoxAscent = 12 
actualBoundingBoxDescent = -4
glyphTop = 12
glyphHeight = 8

After the line
imgData = ctx.getImageData(...)

imgData.data contains pixels:

in original version:
pre

after fix:
aft

@mourner mourner merged commit 05da1b2 into mapbox:main Feb 1, 2022
@mourner mourner mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mourner mourner mourner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@boris-ulyanov @mourner