Merged
Conversation
Contributor
Author
|
It looks like binaries for 0.2.1 were published last year November with https://travis-ci.org/mapbox/vtcomposite/builds/453903028, which added libdeflate to the mix, but was not documented or released on npm. The libdeflate branch isn't merged yet either: #83 @artemp do you remember what happened here? Should we bump to 0.2.2? Or should I republish binaries for 0.2.1? |
springmeyer
approved these changes
Aug 15, 2019
Contributor
springmeyer
left a comment
springmeyer
left a comment
There was a problem hiding this comment.
👍 to republishing over those unused binaries.
Contributor
Author
|
Thanks @springmeyer! Binaries have been rebuilt. Will merge and release on NPM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch protections prevented me from releasing 0.2.1 directly on master, hence the accidental early merge of #103 and the opening of this PR.
Will look for ✅ once binaries are published!
cc @springmeyer @artemp @flippmoke @ericfischer @millzpaugh @ian29