Support languages="all" parameter in localize function#136
Merged
dylannguyen11195 merged 22 commits intomainfrom Oct 7, 2024
Merged
Support languages="all" parameter in localize function#136dylannguyen11195 merged 22 commits intomainfrom
dylannguyen11195 merged 22 commits intomainfrom
Conversation
Contributor
42fcafd to
e90121f
Compare
Contributor
|
Added PR description |
7295d5f to
6da594a
Compare
fba66db to
9181125
Compare
9181125 to
f76e60e
Compare
tercanfurkan
reviewed
Oct 3, 2024
tercanfurkan
reviewed
Oct 3, 2024
Co-authored-by: Ömer Furkan Tercan <tercanfurkan@gmail.com>
tercanfurkan
reviewed
Oct 3, 2024
tercanfurkan
approved these changes
Oct 3, 2024
tercanfurkan
left a comment
There was a problem hiding this comment.
Had some optional suggestions but this LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR handles
languages=allparam forlocalizefunction.Summary of changes:
languages=all: returns original language name and all languages that:hidden_prefixomitted from the property namekeep_every_languagetokeep_all_non_hidden_languagesfor clarityExpected Result:
Logic flow: