-
Notifications
You must be signed in to change notification settings - Fork 14
Closed
Milestone
Description
The set_property method does some variant decoding in the main thread while constructing the final JSON object to return to node. This, in theory, could happen within the worker threads before being handled in the callback, and increase performance.
Lines 154 to 160 in 95ab347
| /// used to create the final v8 (JSON) object to return to the user | |
| void set_property(vtzero::property const& property, | |
| v8::Local<v8::Object>& properties_obj) { | |
| auto val = vtzero::convert_property_value<mapbox::feature::value, mapbox::vector_tile::detail::property_value_mapping>(property.value()); | |
| mapbox::util::apply_visitor(property_value_visitor{properties_obj, std::string(property.key())}, val); | |
| } |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels