Skip to content

Comments

Check for "within" results from closest_point#41

Closed
mapsam wants to merge 1 commit intomasterfrom
pip
Closed

Check for "within" results from closest_point#41
mapsam wants to merge 1 commit intomasterfrom
pip

Conversation

@mapsam
Copy link
Contributor

@mapsam mapsam commented Nov 21, 2017

Refs: #36

This uses the internal boost::geometry::within check from closest_point by checking if the cp_info.distance == 0.0, which is only the case when a within statement returns true. This way we can assign the original query point as the resulting geometry and avoid double->integer->double math.

TODO

  • clean up the conditionals since there's a bit of duplicate code right now
  • benchmarks

cc @flippmoke @artemp

@mapsam
Copy link
Contributor Author

mapsam commented Nov 22, 2017

closing in favor of #42

@mapsam mapsam closed this Nov 22, 2017
@mapsam mapsam deleted the pip branch November 22, 2017 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant