Skip to content

Add Aria2 download support#13

Closed
CodeingBoy wants to merge 7 commits intomaple3142:masterfrom
CodeingBoy:aria2
Closed

Add Aria2 download support#13
CodeingBoy wants to merge 7 commits intomaple3142:masterfrom
CodeingBoy:aria2

Conversation

@CodeingBoy
Copy link
Copy Markdown
Contributor

No description provided.

@CodeingBoy
Copy link
Copy Markdown
Contributor Author

Notice: does not support download more than 1000 files

@maple3142
Copy link
Copy Markdown
Owner

Looks good!
But I don't have time to review this today, maybe tomorrow, sorry!

@CodeingBoy
Copy link
Copy Markdown
Contributor Author

CodeingBoy commented Nov 25, 2019

Looks good!
But I don't have time to review this today, maybe tomorrow, sorry!

No problem.

@maple3142
Copy link
Copy Markdown
Owner

In fact, I doubt whether this has to be implemented in website?
It would be much better to use browser extension do handle this, and it can bypass some limitation too. Such as CORS issues.

It would be better to have a option to let user to easily copy links by selecting files, which is more beneficial than only support 1 download manager(aria2).

@CodeingBoy
Copy link
Copy Markdown
Contributor Author

In fact, I doubt whether this has to be implemented in website?
It would be much better to use browser extension do handle this, and it can bypass some limitation too. Such as CORS issues.

It would be better to have a option to let user to easily copy links by selecting files, which is more beneficial than only support 1 download manager(aria2).

Of course we can separate them, but offering this feature in web interface will be convenient. User can download with aria2 without copy/pasting them or connect this api to their manager. Also, it based on the worker drive API, it's tightly coupled. I think the web interface is the best place it gets implemented.

For some power users copy & pasting urls will fit their needs, but for normal users, handling thousands of files while keeping folder structures intact is difficult. Even they have every files' url, they still needs setting other things, like download directory. It will be very easy by parsing and organizing file info, fill in generated download directory and ships them to aria2. What you need is a few clicks and wait.

For my use case, I have 200+ folders and much more files to download, within several clicks it just gets done.

For exporting urls, you need to think about what should you provide to users. Perhaps they need file name, size, author... What about a selection box? But that will bring much work, so I'm not going to implement this, maybe later.

@maple3142
Copy link
Copy Markdown
Owner

maple3142 commented Nov 26, 2019

@CodeingBoy The problem is this is tighyly coupled with Aria2 only, and this doesn't work for other downloaders such as IDM, JDownloader and so on. And it is unreasonable to expect a website to support all kinds of downloader, so I think this should be handled at user's browser level.

@CodeingBoy
Copy link
Copy Markdown
Contributor Author

@CodeingBoy The problem is this is tighyly coupled with Aria2 only, and this doesn't work for other downloaders such as IDM, JDownloader and so on. And it is unreasonable to expect a website to support all kinds of downloader, so I think this should be handled at user's browser level.

Fine, I will support exporting download urls at weekend.

@CodeingBoy
Copy link
Copy Markdown
Contributor Author

@CodeingBoy The problem is this is tighyly coupled with Aria2 only, and this doesn't work for other downloaders such as IDM, JDownloader and so on. And it is unreasonable to expect a website to support all kinds of downloader, so I think this should be handled at user's browser level.

Fine, I will support exporting download urls at weekend.

Because of Black Friday and Cyber Monday, this feature will be delayed. Stay tuned.

@CodeingBoy
Copy link
Copy Markdown
Contributor Author

@maple3142 I will implement url exporting in another PR. If you think this PR alone is good you can merge it now.

@maple3142
Copy link
Copy Markdown
Owner

I still believe that this should be handled by browser instead, not integrated into this project.
Because there is not reason to only favor Aria2 instead of others.

@CodeingBoy
Copy link
Copy Markdown
Contributor Author

I still believe that this should be handled by browser instead, not integrated into this project.
Because there is not reason to only favor Aria2 instead of others.

Fine, closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants