BIP 0133#81
Open
atticoos wants to merge 1 commit into
Open
Conversation
mappum
requested changes
Dec 11, 2017
Owner
mappum
left a comment
mappum
left a comment
There was a problem hiding this comment.
Thanks for the PRs, I appreciate you keeping this repo up to date! It's cool to see the recent changes in the protocol.
|
|
||
| // BIP 0133 | ||
| feefilter: struct([ | ||
| {name: 'feerate', type: types.buffer8} |
Owner
There was a problem hiding this comment.
Don't mean to nitpick, but I'd like if you added some spacing in the object to keep it consistent with the rest of the file :)
Contributor
Author
There was a problem hiding this comment.
Ofc, I was monkey patching locally when playing with the peer network and decided to PR without cleaning up 😛
Owner
|
BTW, I'll try to figure out what's wrong with the browser tests. |
Contributor
Author
|
Code style updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for BIP 0133
feefiltermessage.feerateis an 8 byte payload, and now added to the known messages