This repository was archived by the owner on Aug 29, 2025. It is now read-only.
include iojs-v3 in travis ci build #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ok, I'll have a look tomorrow. Does it build or not? The iojs 3 changes v8 so maybe a fix is needed... |
Author
|
I attempted to update my app to iojs-3.0.0 today and I don't believe it builds. Thanks for taking a look. This is an incredibly useful tool. |
Owner
|
I've almost done, but seems the new v8 does not triggers GC on requests. I've opened an issue at nodejs/node#2478 |
Author
|
Awesome. Thanks for looking into it. |
marcominetti
pushed a commit
that referenced
this pull request
Aug 21, 2015
include iojs-v3 in travis ci build
Owner
|
The new memwatch compiles but v8 stucks on (memwatch).gc() call in iojs 3.x... In previous iojs/nodejs versions gc works fine. |
Author
|
Thanks for the merge. Helpful in knowing what works/doesn't in 3.0.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @marcominetti, I'm not sure if the build passes in iojs-v3. Thought I'd have travis check it out in a PR.