perf: hoist regex compilation, pre-allocate slices#64
Open
Conversation
…ices Move 12 regexp.MustCompile calls from function bodies to package-level vars in tmux/scraper.go (8), claudemd.go (2), and agentsmd.go (2). This eliminates repeated regex compilation on every scrape cycle. Pre-allocate slices with capacity hints in 3 hot paths: - trends/analyzer.go: hourlyAverage slice with cap 24 - reporting/run_report.go: task result slices with cap len(tasks) - stats/stats.go: report results slice with cap len(entries) Add benchmark tests for parse functions and MD parsers. Nightshift-Task: perf-regression Nightshift-Ref: https://github.com/marcus/nightshift Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
regexp.MustCompilecalls from function bodies to package-level vars acrosstmux/scraper.go(8),claudemd.go(2), andagentsmd.go(2) — eliminates repeated compilation on every scrape cycletrends/analyzer.go,reporting/run_report.go,stats/stats.go)Benchmark results (Apple M4 Pro, arm64)
Scraper parse functions (after hoisting)
Integration MD parsers (after hoisting)
Test plan
go vetpasses on all modified packagesgo build ./...succeeds🤖 Generated with Claude Code
Automated by nightshift