upgrade BlurView android dependency to 2.0.4#626
Merged
Titozzz merged 2 commits intomargelo:masterfrom Aug 29, 2024
Merged
Conversation
This is needed because the older version of `com.github.Dimezis:BlurView:version-2.0.3` is returning malformed shas which annoys our nix setup that expects reproducible builds every time. I noticed that `com.github.Dimezis:BlurView:version-2.0.4` always returns a consistent sha. Example : > curl -s https://jitpack.io/com/github/Dimezis/BlurView/version-2.0.4/BlurView-version-2.0.4.pom | md5sum bc6f937d2ba82396257f6fc5f5247c0d - > curl -s https://jitpack.io/com/github/Dimezis/BlurView/version-2.0.4/BlurView-version-2.0.4.pom | md5sum bc6f937d2ba82396257f6fc5f5247c0d - > curl -s https://jitpack.io/com/github/Dimezis/BlurView/version-2.0.4/BlurView-version-2.0.4.pom | md5sum bc6f937d2ba82396257f6fc5f5247c0d - > curl -s https://jitpack.io/com/github/Dimezis/BlurView/version-2.0.4/BlurView-version-2.0.4.pom | md5sum bc6f937d2ba82396257f6fc5f5247c0d - > curl -s https://jitpack.io/com/github/Dimezis/BlurView/version-2.0.4/BlurView-version-2.0.4.pom | md5sum bc6f937d2ba82396257f6fc5f5247c0d - > curl -s https://jitpack.io/com/github/Dimezis/BlurView/version-2.0.4/BlurView-version-2.0.4.pom | md5sum bc6f937d2ba82396257f6fc5f5247c0d - > curl -s https://jitpack.io/com/github/Dimezis/BlurView/version-2.0.4/BlurView-version-2.0.4.pom | md5sum bc6f937d2ba82396257f6fc5f5247c0d -
This was referenced Aug 29, 2024
|
And a release too, amazing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As you can see below :
com.github.Dimezis:BlurView:version-2.0.3returns different hash randomly so something must be wrong withjitpackand this bothers our setup which usesnixand expects the sameshaeverytime.Solution
A simple solution is to just upgrade and use
com.github.Dimezis:BlurView:version-2.0.4This PR updates that dependency and also adds a nice namespace which is needed for AGP 8.
Thanks for the great work with this library.
@Titozzz
Please do not hesitate to reach out if you have any questions.