fix: Remove jni::ThreadScope and fbjni dependency
#140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
While the idea behind this is good and this increases performance on Android by a tiny bit, this actually might not make sense for the real world. In most cases, you want to run something in a Worklet context that also accesses platform native (Java/Kotlin) APIs, and not just pure JS code. So it makes sense to leave the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
jni::ThreadScopeand fbjni dependency from react-native-worklets-core, as it is implementation specific and we cannot always assume that the user wants a ThreadScope (this is also a performance impact).Instead, the user should implement using a ThreadScope themselves, either via
ThreadScopeorThreadScope::WithClassLoader.cc @chrfalch