Skip to content

Conversation

@eugenelim
Copy link

Remove test/ folder from being published with the npm package

Remove test/ folder from being published with the npm package
@maritz
Copy link
Owner

maritz commented Feb 15, 2018

Any specific reason you want to use this deprecated module still?

I'm not opposed to your change itself, I just don't thing it's actually needed.

@eugenelim
Copy link
Author

we have locked down dependencies for our project release, and I am working on reducing the files pulled down by npm to reduce our deploy time.

@maritz
Copy link
Owner

maritz commented Feb 15, 2018

Okay, but if dependencies are locked down, how is changing a dependency version gonna work? If you can change to the other package, I strongly advise you to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants