chore: update deps, remove deprecated gulp-util#15
chore: update deps, remove deprecated gulp-util#15mariusGundersen merged 2 commits intomariusGundersen:masterfrom avdeev:master
Conversation
package.json
Outdated
| "through2": "~0.6.3" | ||
| "plugin-error": "0.1.2", | ||
| "through2": "2.0.3", | ||
| "vinyl": "2.1.0" |
There was a problem hiding this comment.
vinyl should be in the devDependencies
There was a problem hiding this comment.
How can vinyl be in devDependencies when it's used by the code? Did you mean that it should be in peer-dependencies?
There was a problem hiding this comment.
I only see it used in test.js but I may be missing something. If it's only required for the tests, it should be treated as a dev dependency.
There was a problem hiding this comment.
Yup, my bad, you're right
There was a problem hiding this comment.
@mariusGundersen Thank you! I can fix it in 5 days after holydays. :)
package-lock.json
Outdated
| @@ -0,0 +1,377 @@ | |||
| { | |||
There was a problem hiding this comment.
Using lock files for libraries is not an obvious choice. Please keep this PR only about dropping gulp-util. Unless you know the opinion of the maintainer about it. It may be better to open a second PR if you want to discuss the addition of the lock file.
|
Thank you! I will fix it. |
|
@demurgos @mariusGundersen Remarks in the review have been fixed |
demurgos
left a comment
demurgos
left a comment
There was a problem hiding this comment.
Looks good to me, thanks.
Avoiding changes around lock files does not mean to ignore them, but it's not the core of this PR so I'll avoid bike-shedding about it 😄
@mariusGundersen
Could we have this merged and published?
3 participants
Fix #14