Open
Conversation
Line 106 - Convert rawmsg to bytestring to address exception. Line 222, 227, 257, 336, 341 - Set thread mode to daemon to allow them to terminate when the parent application terminates. Line 270 - Pass 'self' object to getclientcount function to address argument exception and allow function to perform as expected. Line 248 - Rename Server object's "shutdown" method to "close" to coincide with Client object nomenclature and to address the "bool object is not callable" error raised when trying to shutdown a Server object.
Fixed several major issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed pull request fixes Issue #2, as well as several issues I encountered while using this script
List of Changes:
This branch can be automatically merged. Please note the API change in the server object, the shutdown method no longer exists and has been replaced with the close method.