This repository was archived by the owner on Feb 8, 2019. It is now read-only.
CAD-4890: Fix error in our forked gmaps react library #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
i'll make another pr to bump the version in cad-client. |
jatwood
changed the title
Author
|
package-lock was generated because we're using a higher npm version |
|
Huh. Somehow I got pinged for this PR.... wanna check perms Jeff!?
…On Thu, 7 Feb 2019 at 12:33, jatwood ***@***.***> wrote:
i'll make another pr to bump the version in cad-client.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACT-eO_z7fPH20MHm5mp5c3Mj-vHrTuKks5vLGNVgaJpZM4anvKX>
.
|
Author
|
lol i pinged dev ops about it. Hope you're doing well! |
stutrek
approved these changes
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sentry error has been fixed in the google-map-react library (see this issue and this pr). Since we use a forked library we have to copy over that pr. Unfortunately, it's almost impossible to reproduce this error locally, so we can only deploy this and hope the errors disappear. It seems to work based on the thread in the linked issue. I tested that the changed code ran and didn't break stuff in the map.