Copilot/clean up app features#73
Conversation
…rom main screen and delete related code and tests Co-authored-by: markcoleman <229046+markcoleman@users.noreply.github.com>
Co-authored-by: markcoleman <229046+markcoleman@users.noreply.github.com>
|
PR Stats:
Tips for large PRs:
|
⏱️ Build Performance Report
Measured with SPM caching enabled. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3106a50e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private static let defaultSearchConfiguration = CubeSearchConfiguration( | ||
| maxDepthPerSide: 7, | ||
| maxVisitedStates: 300_000 |
There was a problem hiding this comment.
Increase search depth beyond 14 moves
The new default search config caps bidirectional search at maxDepthPerSide: 7, so the solver can only prove solutions up to 14 moves, but many valid Rubik's Cube states require more (the known worst case is 20 moves). In practice this causes legitimate cubes to fail with noSolutionFound/searchLimitReached instead of returning a solution, which breaks normal solve flows for sufficiently scrambled inputs.
Useful? React with 👍 / 👎.
Description
Type of Change
Related Issues
Fixes #(issue)
Relates to #(issue)
Motivation and Context
Changes Made
How Has This Been Tested?
Test Configuration:
Tests Run:
swift test)swiftlint)swift build)Test Details:
Screenshots (if appropriate)
Checklist
Code Quality
Documentation
Testing
Accessibility (if UI changes)
Security Considerations
Details (if applicable):
Breaking Changes
Migration Guide (if needed):
Performance Impact
Details (if applicable):
Additional Notes
For Reviewers: