Improve dev workflow documentation and tooling#74
Conversation
|
PR Stats:
Tips for large PRs:
|
github-actions
Bot
added
size/extra-large
documentation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea77e23779
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| paths: | ||
| - 'Sources/**' | ||
| - 'Tests/**' | ||
| - 'Package.swift' | ||
| - '.swiftlint.yml' | ||
| - 'scripts/pre-commit-check.sh' | ||
| - '.github/workflows/ios-ci.yml' |
There was a problem hiding this comment.
The new paths filter omits .xcode-version, so a PR that only updates the pinned Xcode version will skip this workflow entirely and merge without running lint/build/tests under the new toolchain. Because this file is the repo’s toolchain source-of-truth, excluding it from the trigger can hide breakage until a later unrelated change touches a tracked path.
Useful? React with 👍 / 👎.
| REQUIRED_SWIFT_MAJOR=$(echo "$REQUIRED_SWIFT_TOOLS" | cut -d. -f1) | ||
| if command -v swift >/dev/null 2>&1; then | ||
| SWIFT_VERSION=$(swift --version 2>/dev/null | head -n 1 || echo "unknown") | ||
| if [[ "$SWIFT_VERSION" == *"5.9"* ]] || [[ "$SWIFT_VERSION" == *"5.10"* ]] || [[ "$SWIFT_VERSION" == *"6."* ]]; then | ||
| print_status 0 "Swift version meets minimum requirement (5.9+)" | ||
| INSTALLED_SWIFT_MAJOR=$(echo "$SWIFT_VERSION" | sed -E 's/.*Swift version ([0-9]+)\..*/\1/' || echo "0") | ||
| if [[ "$INSTALLED_SWIFT_MAJOR" =~ ^[0-9]+$ ]] && [ "$INSTALLED_SWIFT_MAJOR" -ge "$REQUIRED_SWIFT_MAJOR" ]; then |
There was a problem hiding this comment.
This check only compares major versions, so with // swift-tools-version: 6.2 an installed Swift 6.0 or 6.1 is reported as compatible even though it does not satisfy the package tools requirement. That gives a misleading “version matches” result and defeats the script’s CI-parity goal for developers on older minor releases.
Useful? React with 👍 / 👎.
1 participant
Summary
.githuband top-level docs to match the updated dev experience goalsAGENTS.md,README.md, and docs/ai/CODEX_WORKFLOW.md stay alignedTesting