Update CubePilot branding and streamline scan UX#77
Conversation
|
PR Stats:
Tips for large PRs:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e579a7197
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| INFOPLIST_KEY_UILaunchScreen_Generation = NO; | ||
| INFOPLIST_KEY_UILaunchStoryboardName = LaunchScreen; |
There was a problem hiding this comment.
Bundle the launch storyboard before enabling it
This change disables the generated launch screen and sets UILaunchStoryboardName to LaunchScreen, but the project file still only lists Assets.xcassets in PBXResourcesBuildPhase and has no PBXFileReference/PBXBuildFile entry for LaunchScreen.storyboard, so iOS builds from this commit won’t include a compiled LaunchScreen.storyboardc. On app startup, the system tries to load that storyboard and can fail to present the launch screen (and in practice may terminate at launch for missing launch storyboard resources).
Useful? React with 👍 / 👎.
Summary
Testing