Skip to content

Conversation

@DmitryEfimenko
Copy link

This change allows to use function generateModuleDeclaration outside of pipe context.
Mostly just code rearrangements so that function generateModuleDeclaration can both - be used by ngHtml2Js function and be exported.
Also updated README to reflect new functionality.
No breaking changes.
The file comparison looks scary, but I just moved code around.

Mostly just code rearrangements so that function
generateModuleDeclaration can be both - be used by ngHtml2Js function
and be exported.
Also updated README to reflect new functionality
No breaking changes.
@DmitryEfimenko
Copy link
Author

hi, hope this could be merged some time soon.
Also, just FYI, I didn't change anything in regards to the versioning. I'm not sure who's supposed to do that and when. Is it the maintainer's responsibility to do that when he's publishing a new version to npm?

@DmitryEfimenko
Copy link
Author

is anybody home?

@mattklein999
Copy link

This would be useful for me as well, please merge in.

@marklagendijk
Copy link
Owner

@DmitryEfimenko what is the use case for this? I think the proper fix for this would be to separate the actual functionality out into its own module, only leave the gulp specific things in this module and depend on that other module.

@DmitryEfimenko
Copy link
Author

I used it in a gulpfile here where I'm attaching converted html to the javascript file. You are right in that extracting this functionality in a separate module would work just fine, but to me it really does not matter much. If such extraction is made, gulp-ng-html2js would consist of 20 lines of code. I don't mind extra 20 lines of code loaded.

@DmitryEfimenko
Copy link
Author

will this be merged? I mean, there really are no breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants