Skip to content

PDP-1182: Remove per-repo pr-workflow.yaml#585

Merged
GAdityaVarma merged 1 commit intodevelopfrom
PDP-1182-remove-pr-workflow-from-develop
Apr 9, 2026
Merged

PDP-1182: Remove per-repo pr-workflow.yaml#585
GAdityaVarma merged 1 commit intodevelopfrom
PDP-1182-remove-pr-workflow-from-develop

Conversation

@SameeraPriyathamTadikonda
Copy link
Copy Markdown
Contributor

@SameeraPriyathamTadikonda SameeraPriyathamTadikonda commented Apr 9, 2026

Summary

Remove per-repo .github/workflows/pr-workflow.yaml from develop branch.

Why

As part of PDP-1182, PR workflows (jira-id-check, copyright-check, trufflehog-scan) are being consolidated into marklogic/pr-workflows and enforced org-wide via a GitHub repository ruleset. The per-repo caller file is no longer needed — the org ruleset fires the centralized workflows automatically on every PR.

What changed

  • Removed .github/workflows/pr-workflow.yaml

References

Copilot AI review requested due to automatic review settings April 9, 2026 01:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the repository-local PR workflow caller now that PR checks are intended to be enforced centrally via an org-wide GitHub ruleset (per PDP-1182).

Changes:

  • Deleted .github/workflows/pr-workflow.yaml (previously calling centralized reusable workflows for JIRA ID and copyright checks).
Comments suppressed due to low confidence (1)

.github/workflows/pr-workflow.yaml:1

  • PR description states PR workflows (including trufflehog-scan) are now enforced org-wide via a ruleset and the per-repo workflow callers are no longer needed. However, this repo still contains a per-repo PR-triggered workflow (.github/workflows/trufflehog.yaml) that will continue running on pull_request to develop, which may cause duplicate checks or confusion. Either remove/disable that workflow as part of this change, or clarify in the PR description why it remains and how it will coexist with the centralized ruleset workflows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GAdityaVarma GAdityaVarma reopened this Apr 9, 2026
@GAdityaVarma GAdityaVarma merged commit 4fc3ea5 into develop Apr 9, 2026
14 checks passed
@GAdityaVarma GAdityaVarma deleted the PDP-1182-remove-pr-workflow-from-develop branch April 9, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants