MLE-28401: Add missing guard for logging retry message#592
Merged
yunzvanessa merged 1 commit intodevelopfrom Apr 14, 2026
Merged
MLE-28401: Add missing guard for logging retry message#592yunzvanessa merged 1 commit intodevelopfrom
yunzvanessa merged 1 commit intodevelopfrom
Conversation
yunzvanessa
force-pushed
the
MLE-28401-fix-retry-logging
branch
from
6d8ce7c to
26c39aa
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes misleading debug logging in DatabaseTransformWriter by ensuring the “Retrying committing batch…” message is only emitted on actual retry attempts, aligning behavior with the existing pattern in TransformWriter.
Changes:
- Add a
commitRetry > 0guard around the retry debug log so it won’t log on the first attempt. - Fix minor punctuation in the log message (“batch ,” → “batch,”).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yunzvanessa
added a commit
that referenced
this pull request
Apr 14, 2026
yunzvanessa
added a commit
that referenced
this pull request
Apr 14, 2026
yunzvanessa
added a commit
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Retrying committing batch" debug message was logged on every batch, even the first attempt, producing misleading output that suggested retries were happening when they weren't. Added a
commitRetry > 0guard to match the existing pattern in the parent classTransformWriter.This issue surfaced when investigating an mlcp regression failure: https://progresssoftware.atlassian.net/browse/MLE-28401