Add options to mask seeds using the pin#34
Open
dylex wants to merge 1 commit intomarkmcavoy:masterfrom
Open
Conversation
This allows much greater security, since the seeds are no longer trivially recoverable if this option is set without the pin. Also provides an even stronger security option to not validate the pin by not storing the hash at all. Instead, incorrect pins just produce incorrect seeds and thus incorrect tokens, making it very difficult to recover the original seeds. (Which of course has its downsides too, if you forget or mis-enter a PIN. We could require the PIN to be entered twice in this case instead.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently seeds are stored cleartext in the database. This option allows greater security, since the seeds are no longer trivially recoverable without the pin if it is set. Also provides an even stronger security option to not validate the pin by not storing the hash at all. Instead, incorrect pins just produce incorrect seeds and thus incorrect tokens, making it very difficult to recover the original seeds. (Which of course has its downsides too, if you forget or mis-enter a PIN. We could require the PIN to be entered twice in this case instead.)
Various refactoring of hex conversion and pin management used therein.