Skip to content

chore: set build.assetsInlineLimit: 0 for SSR tests in dev#157

Merged
DylanPiercey merged 1 commit into
marko-js:mainfrom
sapphi-red:chore/set-build-inline-limit-0
Nov 12, 2024
Merged

chore: set build.assetsInlineLimit: 0 for SSR tests in dev#157
DylanPiercey merged 1 commit into
marko-js:mainfrom
sapphi-red:chore/set-build-inline-limit-0

Conversation

@sapphi-red
Copy link
Copy Markdown
Contributor

Description

This PR fixes ecosystem-ci with Vite v6 beta by setting build.assetsInlineLimit: 0 for SSR tests in dev.

Motivation and Context

Vite 6 now inlines SVG files even in dev that will be inlined for build (vitejs/vite#18581).
That caused the snapshot to change and made the ecosystem-ci to fail.
Because build.assetsInlineLimit: 0 was set for SSR test in build, I set them in dev as well to make the ecosystem-ci pass.

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 77004d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DylanPiercey
Copy link
Copy Markdown
Contributor

Appreciate the pr @sapphi-red, lgtm!

@DylanPiercey DylanPiercey merged commit 99ea902 into marko-js:main Nov 12, 2024
@sapphi-red sapphi-red deleted the chore/set-build-inline-limit-0 branch November 13, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants