AutocompleteInput don't keep focus with mouse

[Nitix]

What you were expecting:
Focus stays in the autocomplete input when selecting an option with mouse

What happened instead:
Component loses the focus and the focus goes to the first element of the page breaking tab navigation

Steps to reproduce:

Go to a form, click on an input with options like SelectInput or AutocompleteInput, select an option, then press tab to try to go to next input. But it fails to do so.

Related code:
No code modification form code sandox https://stackblitz.com/github/marmelab/react-admin/tree/master/examples/simple?file=README.md

Other information:

Screencast.from.2024-03-12.17-09-50.webm

Environment

• React-admin version: 4.16.12
• Last version that did not exhibit the issue (if applicable):
• React version: 18
• Browser: Firefox 123
• Stack trace (in case of a JS error):

[erwanMarmelab]

reproduced, thanks 👍

[fzaninotto]

I can reproduce on AutocompleteInput but not on SelectInput

[Nitix]

My bad, only AutocompleteInput has the bug.

[fzaninotto]

This is the culprit:

react-admin/packages/ra-ui-materialui/src/input/AutocompleteInput.tsx

Line 558 in 717d292

blurOnSelect

Now why did we add this?

[fzaninotto]

This was introduced by #6924, and more specifically by e49fa56

I don't see why we'd want to do that, and I don't think there is a tests for it.

I suggest we remove that option by default (users can re-enable it by hand).