Fix <AutocompleteInput> should keep working when passing custom InputProps#9559
Merged
Fix <AutocompleteInput> should keep working when passing custom InputProps#9559
<AutocompleteInput> should keep working when passing custom InputProps#9559Conversation
adguernier
changed the title
…ops does not exist
djhi
reviewed
Jan 4, 2024
Contributor
djhi
left a comment
djhi
left a comment
There was a problem hiding this comment.
Can you make it more beautiful?
Contributor
Author
Done |
Contributor
Screenshot? |
Contributor
Author
See above, in the description 👆 |
djhi
approved these changes
Jan 5, 2024
slax57
changed the title
<AutocompleteInput> should keep working when passing custom InputProps
fzaninotto
added a commit
that referenced
this pull request
Feb 25, 2024
Autocomplete accepts TextFieldProps, which allows to override the props of the inner TextField (see https://mui.com/material-ui/api/text-field/). This ability was lost in #9559
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Passing
InputPropsto theTextFieldPropsprop of<AutocompleteInput>works but it leads to break theAutocompletebehavior we want to keep.Solution
Merge
InputPropsto apply them AND keep theAutocompletebehavior